On Fri, Mar 04, 2022 at 11:12:07AM +0000, Aaron Tomlin wrote: > On Thu 2022-03-03 05:37 -0800, Christoph Hellwig wrote: > > On Wed, Mar 02, 2022 at 08:56:23PM +0000, Christophe Leroy wrote: > > > Do we really want to hide the 'struct list_head modules' from external > > > world ? > > > > > > Otherwise we could declare it in include/linux/module.h ? > > I'd just move the trivial code that uses it from kernel/kdb/ to > > kernel/module/ as it is tied to module internals and just uses the > > KDB interfaces exposed to other parts of the kernel. > > Hi Christoph, > > This is a great idea. I'll do this instead. Adding this as a new file is fine for me. There were proposed changes to this function this kernel cycle (CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC) which I Acked already. However it looks like all involved with that are already particpating in this thread so I assume an merge issues with that are already in hand. Aaron: Are you OK to add the new kdb file to the "KGDB / KDB /debug_core" file list in MAINTAINERS? Mostly I'd expect to just Ack changes and move on... but I'd like to be in the loop. Daniel.
