Le 22/02/2022 à 12:13, Aaron Tomlin a écrit :
> On Mon 2022-02-21 13:13 +0000, Christophe Leroy wrote:
>>> diff --git a/kernel/Makefile b/kernel/Makefile
>>> index 56f4ee97f328..3a6380975c57 100644
>>> --- a/kernel/Makefile
>>> +++ b/kernel/Makefile
>>
>> This file also contains:
>>
>> KCOV_INSTRUMENT_module.o := n
>>
>> It needs to follow through into kernel/module/Makefile, with a copy of
>> the comment. And then it needs to be taken care of while dismantling main.c
>
> Christophe,
>
> I do not see why this is necessary.
>
>
I don't know.
The comment says:
# These are called from save_stack_trace() on slub debug path,
# and produce insane amounts of uninteresting coverage.
This was brought by commit 5c9a8750a640 ("kernel: add kcov code coverage")
Since then, some architectures don't have save_stack_trace() anymore as
they were converted to generic ARCH_STACKWALK.
It was done on powerpc by commit a1cdef04f22d ("powerpc: Convert
stacktrace to generic ARCH_STACKWALK")
Whatever you decide to do, you can't leave this in kernel/Makefile as
module.o is gone.
Christophe
