On Mon 2022-02-21 06:31 +0000, Christophe Leroy wrote: > CC kernel/module/strict_rwx.o > In file included from ./include/linux/build_bug.h:5, > from ./include/linux/container_of.h:5, > from ./include/linux/list.h:5, > from ./include/linux/module.h:12, > from kernel/module/strict_rwx.c:8: > kernel/module/strict_rwx.c: In function 'frob_rodata': > kernel/module/strict_rwx.c:16:17: error: implicit declaration of > function 'PAGE_ALIGNED'; did you mean 'IS_ALIGNED'? > [-Werror=implicit-function-declaration] > 16 | BUG_ON(!PAGE_ALIGNED(layout->base)); > | ^~~~~~~~~~~~ > ./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' > 78 | # define unlikely(x) __builtin_expect(!!(x), 0) > | ^ > kernel/module/strict_rwx.c:16:9: note: in expansion of macro 'BUG_ON' > 16 | BUG_ON(!PAGE_ALIGNED(layout->base)); > | ^~~~~~ > cc1: some warnings being treated as errors > make[2]: *** [scripts/Makefile.build:288 : kernel/module/strict_rwx.o] > Erreur 1 > > > > You have to include <linux/mm.h> Christophe, Strange, I have not seen this before. Locally, looking at kernel/module/strict_rwx.i it is eventually included. Anyhow, you are right. Also, it will not hurt due to the multiple-include optimisation found in include/linux/mm.h. Kind regards, -- Aaron Tomlin
