Re: [PATCH 8/8] modinfo: Allow to force arg as module name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 16, 2022 at 10:47:36AM -0800, Luis Chamberlain wrote:
On Tue, Feb 15, 2022 at 11:55:33PM -0800, Lucas De Marchi wrote:
With the new -m|--modname option it's possible to query the information about this (builtin):

Query what information?

any of the fields exposed by the module or builtin. The phrase got
truncated by wrong copy and paste. See below


	$ modinfo --modname crc32
	module explicitly:

explicitly seems a bit odd, its not clear if the information below
is because its a module or what. Maybe module details?

ugh... this was a wrong copy/paste in the commit message. That "module
explicitely" is not in the output at all, and was rather part of the
previous paragraph. It should had been something like:


With the new -m|--modname option it's possible to query the information
about this (builtin) module explicitly:

	$ ./build.new/tools/modinfo --modname crc32
	name:           crc32
	filename:       (builtin)
	license:        GPL
	file:           lib/crc32
	description:    Various CRC32 calculations
	author:         Matt Domsch <Matt_Domsch@xxxxxxxx>


	name:           crc32
	filename:       (builtin)

You know a --is-built-in option might be nice while you're at it.
Unless we already have something like this on another tool.

to just check if a module is built-in or not? Not sure if it would be in
modinfo or modprobe (since modprobe historically got the -R to resolve
an alias).




Other than that:

Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

thanks
Lucas De Marchi



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux