Hi Luis, As per your suggestion [1], this is an attempt to refactor and split optional code out of core module support code into separate components. This version is based on branch mcgrof/modules-next since a97ac8cb24a3/or modules-5.17-rc1. Please let me know your thoughts. Changes since v1 [2]: - Moved module version support code into a new file Changes since v2 [3]: - Moved module decompress support to a separate file - Made check_modinfo_livepatch() generic (Petr Mladek) - Removed filename from each newly created file (Luis Chamberlain) - Addressed some (i.e. --ignore=ASSIGN_IN_IF,AVOID_BUG was used) minor scripts/checkpatch.pl concerns e.g., use strscpy over strlcpy and missing a blank line after declarations (Allen) Changes since v3 [4]: - Refactored both is_livepatch_module() and set_livepatch_module(), respectively, to use IS_ENABLED(CONFIG_LIVEPATCH) (Joe Perches) - Addressed various compiler warnings e.g., no previous prototype (0-day) [1]: https://lore.kernel.org/lkml/YbEZ4HgSYQEPuRmS@xxxxxxxxxxxxxxxxxxxxxx/ [2]: https://lore.kernel.org/lkml/20211228213041.1356334-1-atomlin@xxxxxxxxxx/ [3]: https://lore.kernel.org/lkml/20220106234319.2067842-1-atomlin@xxxxxxxxxx/ [4]: https://lore.kernel.org/lkml/20220128203934.600247-1-atomlin@xxxxxxxxxx/ Aaron Tomlin (13): module: Move all into module/ module: Simple refactor in preparation for split module: Move livepatch support to a separate file module: Move latched RB-tree support to a separate file module: Move arch strict rwx support to a separate file module: Move strict rwx support to a separate file module: Move extra signature support out of core code module: Move kmemleak support to a separate file module: Move kallsyms support into a separate file module: Move procfs support into a separate file module: Move sysfs support into a separate file module: Move kdb_modules list out of core code module: Move version support into a separate file MAINTAINERS | 2 +- include/linux/module.h | 64 +- kernel/Makefile | 5 +- kernel/debug/kdb/kdb_main.c | 5 + kernel/module-internal.h | 50 - kernel/module/Makefile | 20 + kernel/module/arch_strict_rwx.c | 44 + kernel/module/debug_kmemleak.c | 30 + .../decompress.c} | 2 +- kernel/module/internal.h | 236 +++ kernel/module/kallsyms.c | 502 +++++ kernel/module/livepatch.c | 74 + kernel/{module.c => module/main.c} | 1874 +---------------- kernel/module/procfs.c | 142 ++ .../signature.c} | 0 kernel/module/signing.c | 120 ++ kernel/module/strict_rwx.c | 83 + kernel/module/sysfs.c | 425 ++++ kernel/module/tree_lookup.c | 109 + kernel/module/version.c | 110 + kernel/module_signing.c | 45 - 21 files changed, 2038 insertions(+), 1904 deletions(-) delete mode 100644 kernel/module-internal.h create mode 100644 kernel/module/Makefile create mode 100644 kernel/module/arch_strict_rwx.c create mode 100644 kernel/module/debug_kmemleak.c rename kernel/{module_decompress.c => module/decompress.c} (99%) create mode 100644 kernel/module/internal.h create mode 100644 kernel/module/kallsyms.c create mode 100644 kernel/module/livepatch.c rename kernel/{module.c => module/main.c} (63%) create mode 100644 kernel/module/procfs.c rename kernel/{module_signature.c => module/signature.c} (100%) create mode 100644 kernel/module/signing.c create mode 100644 kernel/module/strict_rwx.c create mode 100644 kernel/module/sysfs.c create mode 100644 kernel/module/tree_lookup.c create mode 100644 kernel/module/version.c delete mode 100644 kernel/module_signing.c base-commit: a97ac8cb24a3c3ad74794adb83717ef1605d1b47 -- 2.34.1
