Hi Lucas, > On Thu, Jan 28, 2021 at 5:02 AM Michal Suchánek <msuchanek@xxxxxxx> wrote: > > Hello, > > kmod version 28 adds support for zstd. The support is optional but when > > not enabled the depmod test which unconditionally tests zstd fails. > > As kmod supports more and more compression methods I think it is not > > reasonable to expect everyone has all copression libraries available. > > Do you think it is reasonable to fix the tests to only use teh > > compresion methods enabled by configure? > We specifically added support for skipping tests when the build > options would imply that the test > would fail. It should not be failing, we probably screwed something up. I noticed that and backported both related patches during backport: 847247a testsuite: Automatically skip tests that fail when sysconfdir != /etc. b5683f4 testsuite: Add facility to skip tests. but it failed. Also running master with: ./autogen.sh && ./configure CFLAGS='-g -O2' --enable-debug --with-zstd --with-xz --with-zlib --with-openssl && ma && ma check fails on testsuite/test-depmod: depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory TESTSUITE: running depmod_search_order_override, in forked context TESTSUITE: SKIPPED: depmod_search_order_override TESTSUITE: ------ TESTSUITE: running depmod_search_order_external_last, in forked context TESTSUITE: 'depmod_search_order_external_last' [649] exited with return code 0 TESTSUITE: PASSED: depmod_search_order_external_last TESTSUITE: ------ TESTSUITE: running depmod_search_order_external_first, in forked context TESTSUITE: SKIPPED: depmod_search_order_external_first TESTSUITE: ------ TESTSUITE: running depmod_detect_loop, in forked context TESTSUITE: SKIPPED: depmod_detect_loop TESTSUITE: ------ TESTSUITE: running depmod_search_order_same_prefix, in forked context TESTSUITE: 'depmod_search_order_same_prefix' [650] exited with return code 0 TESTSUITE: ERR: sizes do not match testsuite/rootfs/test-depmod/search-order-same-prefix/lib/modules/4.4.4/correct-modules.dep testsuite/rootfs/test-depmod/search-order-same-prefix/lib/modules/4.4.4/modules.dep TESTSUITE: ERR: FAILED: exit ok but outputs do not match: depmod_search_order_same_prefix TESTSUITE: ------ FAIL testsuite/test-depmod (exit status: 1) Kind regards, Petr
