Lucas De Marchi <lucas.de.marchi@xxxxxxxxx> writes:
> On Sat, May 16, 2020 at 6:04 AM Marius Bakke <marius@xxxxxxxx> wrote:
>>
>> The Makefile helpfully warns that some tests will fail when
>> --sysconfdir != /etc, but there are no provisions to easily disable
>> those. This commit provides an escape hatch.
>
> nice... but are we missing a patch to actually make it skip?
Uh... That makes sense. (I maintained a list down-stream, derp.)
>> @@ -948,6 +949,14 @@ static inline int test_run_parent(const struct test *t, int fdout[2],
>> int err;
>> bool matchout, match_modules;
>>
>> + if (t->skip == true) {
>
> only if (t->skip) would be less verbose and preferred I think.
Fixed in v2, thanks!
Marius Bakke (2):
testsuite: Add facility to skip tests.
testsuite: Automatically skip tests that fail when sysconfdir != /etc.
Makefile.am | 12 +++++-------
configure.ac | 2 ++
testsuite/test-blacklist.c | 3 +++
testsuite/test-depmod.c | 12 ++++++++++++
testsuite/test-modprobe.c | 6 ++++++
testsuite/testsuite.c | 9 +++++++++
testsuite/testsuite.h | 1 +
7 files changed, 38 insertions(+), 7 deletions(-)
Attachment:
signature.asc
Description: PGP signature
