Re: [PATCH 1/2] libkmod: ignore kcmdline option if we fail to parse modname

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Both patches applied.

Lucas De Marchi

On Tue, Mar 10, 2020 at 01:23:07AM -0700, Lucas De Marchi wrote:
The error message is saying we are ignoring the option on the kernel
command line, so just do it.
---
libkmod/libkmod-config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libkmod/libkmod-config.c b/libkmod/libkmod-config.c
index 7b62367..971f20b 100644
--- a/libkmod/libkmod-config.c
+++ b/libkmod/libkmod-config.c
@@ -488,8 +488,9 @@ static void kcmdline_parse_result(struct kmod_config *config, char *modname,
		if (underscores(modname) < 0) {
			ERR(config->ctx, "Ignoring bad option on kernel command line while parsing module name: '%s'\n",
			    modname);
+		} else {
+			kmod_config_add_options(config, modname, param);
		}
-		kmod_config_add_options(config, modname, param);
	}
}

--
2.25.1




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux