Re: [PATCH] libkmod-module: convert return value from system() to errno

Topi Miettinen <toiwoton@xxxxxxxxx> · Tue, 24 Dec 2019 11:54:58 +0200

On 24.12.2019 4.54, Lucas De Marchi wrote:
On Mon, Dec 23, 2019 at 9:07 AM Topi Miettinen <toiwoton@xxxxxxxxx> wrote:

Don't use exit status of a command directly as errno code, callers
will be confused.

Signed-off-by: Topi Miettinen <toiwoton@xxxxxxxxx>
---
   libkmod/libkmod-module.c | 8 +++++---
   1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
index 8044a8f..6031d80 100644
--- a/libkmod/libkmod-module.c
+++ b/libkmod/libkmod-module.c
@@ -983,11 +983,13 @@ static int command_do(struct kmod_module *mod,
const char *type,
          if (err == -1 || WEXITSTATUS(err)) {
                  ERR(mod->ctx, "Error running %s command for %s\n",
                                                                  type,
modname);
-               if (err != -1)
-                       err = -WEXITSTATUS(err);

I don't think we actually care about differentiating them. So just a plain
return -EINVAL;  here would suffice, makes sense?

I think it would lose potentially valuable information. For example 
EPERM could tell the system administrator of a problem with MAC 
configuration preventing execution of the shell, ENOENT could show that 
the shell or shared libraries are missing and so forth.

-Topi






