Re: Buffer overflow in modprobe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I am not the author of the change, the change was suggested to us as
part of the report that we received.

I can still try to send it in as a patch.

Cheers,
Jorge

On Wed, Dec 18, 2019 at 7:45 PM Lucas De Marchi
<lucas.demarchi@xxxxxxxxx> wrote:
>
> On Thu, Dec 12, 2019 at 02:16:18PM -0500, Jorge Lucangeli Obes wrote:
> >Reset the state of was_space to false between passes.
> >For your assistance, we have provided the following code:
> >
> >--- libkmod-config.c            2018-06-21 17:59:48.633600181 +0100
> >+++ libkmod-config.fixed        2018-09-12 21:42:34.499453017 +0100 @@
> >-333,6 +333,8 @@
> >                memcpy(dep->name ,modname ,modnamelen);
> >+        was_space = false;
> >+               /* copy strings */
>
> this looks reasonable. Are you the author of such change? Could you send
> this as a patch with git send-email?
>
> It would be nice to have a test added to the testsuite too if you can.
>
> thanks
> Lucas De Marchi
>
>
> >               itr = dep->name + modnamelen;
> >               n_pre = 0;



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux