Re: [PATCH kmod] libkmod-signature: implement pkcs7 parsing with openssl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Lucas!

>>>>> On Tue, 29 Jan 2019 10:03:45 -0800, Lucas De Marchi  wrote:

[...]

 >> > yes, my idea was to just leave it simpler and add a
 >> 
 >> > if (pkcs7)
 >> >        free(key_id)
 >> 
 >> Ah, got it, thanks!
 >> 
 >> Well, if it's not a show stopper for you, I would rather keep it
 >> as in the original proposal since it does not inject
 >> implementation details to the upper level.

 > ok, we may revisit this later. What's the status of the test
 > for testsuite?

Haven't checked yet, sorry (caught some flu).

 > Are you going to send a v2 (3?) including the test?

Yes if everything finally works.

-- 
WBR,
Yauheni Kaliuta



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux