On Fri, Nov 23, 2018 at 11:53:20PM +0200, Yauheni Kaliuta wrote: > Hi! > > I'm not very happy with the naming, but how do you like the idea in general? I don't like the naming, too. The idea is good and I like the de-duplication of the implementation, thanks. These are all symbols, but coming from different elf sections. I wonder if we can add a kmod_module_get_symbols2() with an additional argument. then we would still have kmod_module_symbol_get_symbol(), kmod_module_symbol_get_crc() and add kmod_module_symbol_get_bind_type() And these will need to be added to the testsuite thoughts? Lucas De Marchi > > > Yauheni Kaliuta (2): > libkmod: module: introduce common symbol API. > libkmod: module: make old symbol access API as wrapper to the new > > libkmod/libkmod-module.c | 387 ++++++++++++++++----------------------- > libkmod/libkmod.h | 12 ++ > 2 files changed, 171 insertions(+), 228 deletions(-) > > -- > 2.19.1 >
