On Fri, Aug 3, 2018 at 2:10 PM Tobias Stoeckmann <tobias@xxxxxxxxxxxxxx> wrote: > > On Fri, Aug 03, 2018 at 02:07:34PM -0700, Lucas De Marchi wrote: > > > + if ((uintmax_t)st.st_size > (uintmax_t)SIZE_MAX) > > > > why casting? > > Without casting, a warning could be triggered on 64 bit systems, > because on these systems a signed 64 bit int (off_t) is compared > with an unsigned 64 bit int (size_t) which could never be larger. > > Casting it to uintmax_t, which is at least 64 bits in size, > silences this error. so you are casting the *sign* away, ok. But casting only st.st_size should suffice. Lucas De Marchi > > No technical reason beyond that. > > > Tobias -- Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
