Re: [PATCH kmod 3/3] tools: display features together with version information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, Jun 07, 2015 at 03:27:29AM -0300, lucas.de.marchi@xxxxxxxxx wrote:
> From: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> diff --git a/tools/kmod.c b/tools/kmod.c
> index c9d2cc8..28217df 100644
> --- a/tools/kmod.c
> +++ b/tools/kmod.c
> @@ -114,6 +114,7 @@ static int handle_kmod_commands(int argc, char *argv[])
>  			return EXIT_SUCCESS;
>  		case 'V':
>  			puts("kmod version " VERSION);
> +			puts(KMOD_FEATURES);
>  			return EXIT_SUCCESS;

Hmm - seems kmod.c is the only component
which open-codes literals
rather than making use of PACKAGE define?
If this is not intended,
then it would probably be useful
to have another correction commit prior to this one
included in the series,
to have this one gain properly fully symmetric content.

> diff --git a/tools/modinfo.c b/tools/modinfo.c
> index 94d55c9..86ac04b 100644
> --- a/tools/modinfo.c
> +++ b/tools/modinfo.c
> @@ -405,6 +405,7 @@ static int do_modinfo(int argc, char *argv[])
>  			return EXIT_SUCCESS;
>  		case 'V':
>  			puts(PACKAGE " version " VERSION);
> +			puts(KMOD_FEATURES);
>  			return EXIT_SUCCESS;

Thanks,

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux