Re: [PATCH] build: generate libkmod.pc during autoconf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jeff,

On Thu, Mar 5, 2015 at 6:05 PM, Jeff Waugh <jdub@xxxxxxxxxxxxxxx> wrote:
> The pkgconfig file is generated at make-time, leading to absolute /usr/include
> & /usr/lib search paths. The patch lets autoconf handle pkgconfig file subst,

what exactly are you solving here? What's the problem with doing it
during make not during configure?
We have it in Makefile.am exactly so it's processed by make, not
configure. Make runs after configure so it will use whatever is
configured to make the substitution.

$ ./configure --includedir=/tmp/bla
$ make
$ grep includedir= ./libkmod/libkmod.pc
$ includedir=/tmp/bla

> like other packages do. (Patch from OpenWrt's contributed packages project.)

others do like we do, too:
https://git.kernel.org/cgit/linux/kernel/git/kay/libabc.git/tree/Makefile.am
http://cgit.freedesktop.org/systemd/systemd/tree/Makefile.am

should they be changed, too?

-- 
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux