Re: [PATCH] libkmod: properly validate file size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Feb 10, 2015 at 4:46 PM, Tobias Stoeckmann
<tobias@xxxxxxxxxxxxxx> wrote:
> Hi,
>
> in function kmod_elf_new, the file size has to be properly validated against
> section offset. Currently, the file size is considered valid based on
> ELF header size + section header size * section count. That is not sufficient.
>
> In fact, ELF specifies a section header offset, which doesn't have to be the
> size of the ELF header. The supplied test cases even cover this.

the supplied test cases? which test cases?

> The correct test is: section offset + section header size * section count

I'm not sure about this anymore without looking up to the
specification. Could you point here in the commit message?


thanks
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux