Re: [PATCH] build: Do not force diagnostics-color flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 16, 2014 at 9:27 PM, Mike Auty <ikelos@xxxxxxxxxx> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hiya,
>
> On 16/12/14 20:46, Lucas De Marchi wrote:
>> Do we really need to specify the colors ourselves? Systemd's
>> commit seems to only export any value in the variable to get the
>> default ones.
>
> No, but if the data isn't important anyway, I figured we might as well
> load it with the default value as something useful for anyone that
> happens to read the line.  Submitting what was in the systemd patch
> seemed embarrassing, but if you think it's more confusing then I'm
> happy to include some bogus text of your choosing.

The problem is that then we don't follow whatever the default becomes
when a new gcc is released. A simple "yes" instead of "oh, shiny"
would do the job, too :-)

I'm amending it to your patch and applying.

Thanks
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux