Re: [PATCH 4/8] testsuite: add test for '.' correctly parsed in param's value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-03-06 15:06, Lucas De Marchi wrote:
> In kcmdline it's possible to have a dot in the param's value. The
> support for this was added in 66f3228 ("libkmod: Add support for '.' in
> module parameter on kcmdline") and is needed to correctly support some
> modules that depend on it.

The tests look OK. I tried to revert my fix and the test failed.


> This test was added in order to make sure the commit  aa87854
> ("libkmod-config: Only match dot before '=' in /proc/cmdline") didn't
> break it. Although that commit  message says it's allowing to match a
> dot before '=' it's actually enforcing the first part of the string to
> be always in the format "<module-name>.param". Dots after '=' are still
> correctly allowed.

Yeah, the wording was not really clear.

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux