Re: [PATCH] Makefile.am: add mkdir testsuite and standaline build target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Saul,

On Wed, Oct 9, 2013 at 7:53 PM, Saul Wold <sgw@xxxxxxxxxxxxxxx> wrote:
> If we are not building in the existing source tree, the testsuite
> directory will not exist so the cp of the stamp-rootfs would fail.
>
> Also added buildtest-TESTS so they could be build in the cross env,
> without running the tests.
>
> Signed-off-by: Saul Wold <sgw@xxxxxxxxxxxxxxx>
> ---
>  Makefile.am | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index c165868..018e6ed 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -131,7 +131,7 @@ endif
>
>  ROOTFS = testsuite/rootfs
>  ROOTFS_PRISTINE = $(top_srcdir)/testsuite/rootfs-pristine
> -CREATE_ROOTFS = $(AM_V_GEN) ( $(RM) -rf $(ROOTFS) && \
> +CREATE_ROOTFS = $(AM_V_GEN) ( $(RM) -rf $(ROOTFS) && mkdir -p $(dir $(ROOTFS)) && \

I think it's something else that's causing a failure for you.  The
following works for me:

$ ./autogen.sh
$ cd /tmp/build
$ $OLDPWD/configure --sysconfdir=/etc --with-zlib && make -j10 check

You really need the --sysconfdir=/etc and --with-zlib otherwise some
tests will fail.  These are the flags we pass to distcheck, that also
builds out of tree (but in an inner directory)

>                                 cp -r $(ROOTFS_PRISTINE) $(ROOTFS) && \
>                                 touch testsuite/stamp-rootfs && \
>                                 find $(ROOTFS) -type d -exec chmod +w {} \; )
> @@ -217,6 +217,9 @@ DISTCHECK_CONFIGURE_FLAGS=--enable-gtk-doc --sysconfdir=/etc --with-zlib
>
>  distclean-local: $(DISTCLEAN_LOCAL_HOOKS)
>
> +buildtest-TESTS:
> +       $(MAKE) $(AM_MAKEFLAGS) $(check_LTLIBRARIES) $(check_PROGRAMS)
> +

Makes sense. Splitting the patch would be good.

Thanks
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux