On Tue, Feb 12, 2013 at 8:32 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > The first argument to mmap should be "NULL" instead of "0". > --- > libkmod/libkmod-index.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libkmod/libkmod-index.c b/libkmod/libkmod-index.c > index 516240e..d386f00 100644 > --- a/libkmod/libkmod-index.c > +++ b/libkmod/libkmod-index.c > @@ -801,9 +801,9 @@ struct index_mm *index_mm_open(struct kmod_ctx *ctx, const char *filename, > if ((size_t) st.st_size < sizeof(hdr)) > goto fail_nommap; > > - if ((idx->mm = mmap(0, st.st_size, PROT_READ, MAP_PRIVATE, fd, 0)) > + if ((idx->mm = mmap(NULL, st.st_size, PROT_READ, MAP_PRIVATE, fd, 0)) > == MAP_FAILED) { > - ERR(ctx, "mmap(0, %"PRIu64", PROT_READ, %d, MAP_PRIVATE, 0): %m\n", > + ERR(ctx, "mmap(NULL, %"PRIu64", PROT_READ, %d, MAP_PRIVATE, 0): %m\n", > st.st_size, fd); > goto fail_nommap; > } > -- Please correct the split of these patches and bring the change in the first patch to this one. Otherwise looks good. Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html