Re: [PATCH] insmod, modprobe: propagate error status from module insertion to exit code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 28, 2012 at 8:43 PM, Daniel Dadap <ddadap@xxxxxxxxxx> wrote:
> insmod and modprobe return STATUS_FAILURE when module insertion fails,
> regardless of the reason. Since distinguishing between specific failure
> cases might be useful for callers of these utilities, it makes sense to
> propagate the error code from insertion to the exit status.

relying on the return code of a binary is one thing that can break
very easily.  Could you share why you need to distinguish between the
causes of failures.  This might as well break current code which
relies on the current return code.


>
> Signed-off-by: Daniel Dadap <ddadap@xxxxxxxxxx>
> Reviewed-by:   Andy Ritger  <aritger@xxxxxxxxxx>

btw we don't use s-o-b in kmod.


Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux