Hi Sami, On Sun, Oct 21, 2012 at 3:30 PM, Sami Kerola <kerolasa@xxxxxx> wrote: > Before this commit the build system failed with non-helpful message, when > xsltproc was not found. > > Making all in man > GEN depmod.d.5 > /bin/sh: --nonet: command not found > make[2]: *** [depmod.d.5] Error 127 > make[1]: *** [all-recursive] Error 1 > make: *** [all] Error 2 > > Signed-off-by: Sami Kerola <kerolasa@xxxxxx> We don't use signed-off-by in kmod. > --- > configure.ac | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 2e9124c..a72f3f2 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -31,7 +31,11 @@ AC_C_BIGENDIAN > > AC_PROG_SED > AC_PROG_MKDIR_P > -AC_PATH_PROG([XSLTPROC], [xsltproc]) > +AC_PATH_PROG([XSLTPROC], [xsltproc], [no]) > +if test "x$XSLTPROC" = "xno" ; then > + echo '*** xsltproc command was not found from $PATH. Disabling manual build.' > + enable_manpages=no > +fi It indeed needs fixing, but I'm no fan of these automagic detections. We already got a --disable-manpages. If user didn't use that, we should not disable it. So if there's no xsltproc, failing the configure here is the right thing to do. Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
