On Wed, Feb 22, 2012 at 11:56 PM, Dan McGee <dan@xxxxxxxxxxxxx> wrote: > The current configuration is dumb in any number of ways: > 1) If the rationale was for space savings, it works the opposite- the > git repo gets more bloated because we are adding binary compressed > blobs that share little in common with their parent, and anyone that > wants to run the test suite has to unzip it anyway. > 2) It is a pain in the butt to add new tests, and not accidentally lose > any new rootfs you built in the directory. > 3) `git status` won't help you if you are tweaking files in the rootfs > and don't know they have been changed, or if some test did that and > you couldn't detect it. > 4) `git log` won't help you find out what is changing in the rootfs test > directory itself when changes are made to the binary blob, such as > new files being added or even existing files being tweaked. > 5) The files just aren't that big anyway- 2.7MB unzipped. > --- Actual patch available here, as it is too large to email: http://www.toofishes.net/uploads/0001-testsuite-ship-testsuite-rootfs-unzipped.patch.gz > Makefile.am | 15 ------- > testsuite/.gitignore | 1 - > testsuite/rootfs/test-alias/correct.txt | 25 +++++++++++ > testsuite/rootfs/test-loaded/correct.txt | 2 + > testsuite/rootfs/test-loaded/proc/modules | 1 + > .../test-loaded/sys/module/btusb/drivers/usb:btusb | 1 + > .../rootfs/test-loaded/sys/module/btusb/initstate | 1 + > .../sys/module/btusb/notes/.note.gnu.build-id | Bin 0 -> 36 bytes > .../sys/module/btusb/parameters/disable_scofix | 1 + > .../sys/module/btusb/parameters/force_scofix | 1 + > .../sys/module/btusb/parameters/ignore_csr | 1 + > .../sys/module/btusb/parameters/ignore_dga | 1 + > .../sys/module/btusb/parameters/ignore_sniffer | 1 + > .../test-loaded/sys/module/btusb/parameters/reset | 1 + > .../rootfs/test-loaded/sys/module/btusb/refcnt | 1 + > .../test-loaded/sys/module/btusb/sections/.bss | 1 + > .../test-loaded/sys/module/btusb/sections/.data | 1 + > .../sys/module/btusb/sections/.exit.text | 1 + > .../btusb/sections/.gnu.linkonce.this_module | 1 + > .../sys/module/btusb/sections/.init.text | 1 + > .../sys/module/btusb/sections/.note.gnu.build-id | 1 + > .../test-loaded/sys/module/btusb/sections/.rodata | 1 + > .../sys/module/btusb/sections/.rodata.str1.1 | 1 + > .../sys/module/btusb/sections/.rodata.str1.8 | 1 + > .../sys/module/btusb/sections/.smp_locks | 1 + > .../test-loaded/sys/module/btusb/sections/.strtab | 1 + > .../test-loaded/sys/module/btusb/sections/.symtab | 1 + > .../test-loaded/sys/module/btusb/sections/.text | 1 + > .../test-loaded/sys/module/btusb/sections/__param | 1 + > .../rootfs/test-loaded/sys/module/btusb/srcversion | 1 + > .../rootfs/test-loaded/sys/module/btusb/version | 1 + > testsuite/rootfs/test-modinfo/correct.txt | 28 ++++++++++++ > testsuite/rootfs/test-modinfo/ext4-i686.ko | Bin 0 -> 437788 bytes > testsuite/rootfs/test-modinfo/ext4-ppc64.ko | Bin 0 -> 704776 bytes > testsuite/rootfs/test-modinfo/ext4-s390x.ko | Bin 0 -> 773856 bytes > testsuite/rootfs/test-modinfo/ext4-x86_64.ko | Bin 0 -> 627040 bytes > .../builtin/lib/modules/4.4.4/modules.alias | 1 + > .../builtin/lib/modules/4.4.4/modules.alias.bin | Bin 0 -> 12 bytes > .../builtin/lib/modules/4.4.4/modules.builtin | 1 + > .../builtin/lib/modules/4.4.4/modules.builtin.bin | Bin 0 -> 31 bytes > .../builtin/lib/modules/4.4.4/modules.dep.bin | Bin 0 -> 12 bytes > .../builtin/lib/modules/4.4.4/modules.devname | 1 + > .../builtin/lib/modules/4.4.4/modules.softdep | 2 + > .../builtin/lib/modules/4.4.4/modules.symbols | 1 + > .../builtin/lib/modules/4.4.4/modules.symbols.bin | Bin 0 -> 12 bytes > .../test-modprobe/show-depends/correct-psmouse.txt | 1 + > .../rootfs/test-modprobe/show-depends/correct.txt | 2 + > .../4.4.4/kernel/drivers/bluetooth/btusb.ko | Bin 0 -> 28134 bytes > .../4.4.4/kernel/drivers/input/mouse/psmouse.ko | Bin 0 -> 95649 bytes > .../4.4.4/kernel/net/bluetooth/bluetooth.ko | Bin 0 -> 284834 bytes > .../show-depends/lib/modules/4.4.4/modules.alias | 21 +++++++++ > .../lib/modules/4.4.4/modules.alias.bin | Bin 0 -> 1227 bytes > .../show-depends/lib/modules/4.4.4/modules.dep | 3 + > .../show-depends/lib/modules/4.4.4/modules.dep.bin | Bin 0 -> 298 bytes > .../show-depends/lib/modules/4.4.4/modules.devname | 1 + > .../show-depends/lib/modules/4.4.4/modules.softdep | 2 + > .../show-depends/lib/modules/4.4.4/modules.symbols | 45 ++++++++++++++++++++ > .../lib/modules/4.4.4/modules.symbols.bin | Bin 0 -> 2390 bytes > .../rootfs/test-modprobe/show-depends/proc/modules | 2 + > .../show-depends/sys/module/bluetooth/coresize | 1 + > .../sys/module/bluetooth/holders/btusb | 1 + > .../show-depends/sys/module/bluetooth/initsize | 1 + > .../show-depends/sys/module/bluetooth/initstate | 1 + > .../sys/module/bluetooth/notes/.note.gnu.build-id | Bin 0 -> 36 bytes > .../sys/module/bluetooth/parameters/disable_ertm | 1 + > .../sys/module/bluetooth/parameters/disable_esco | 1 + > .../sys/module/bluetooth/parameters/enable_hs | 1 + > .../sys/module/bluetooth/parameters/enable_le | 1 + > .../sys/module/bluetooth/parameters/enable_mgmt | 1 + > .../show-depends/sys/module/bluetooth/refcnt | 1 + > .../sys/module/bluetooth/sections/.bss | 1 + > .../sys/module/bluetooth/sections/.data | 1 + > .../sys/module/bluetooth/sections/.exit.text | 1 + > .../bluetooth/sections/.gnu.linkonce.this_module | 1 + > .../sys/module/bluetooth/sections/.init.text | 1 + > .../module/bluetooth/sections/.note.gnu.build-id | 1 + > .../sys/module/bluetooth/sections/.rodata | 1 + > .../sys/module/bluetooth/sections/.rodata.str1.1 | 1 + > .../sys/module/bluetooth/sections/.rodata.str1.8 | 1 + > .../sys/module/bluetooth/sections/.smp_locks | 1 + > .../sys/module/bluetooth/sections/.strtab | 1 + > .../sys/module/bluetooth/sections/.symtab | 1 + > .../sys/module/bluetooth/sections/.text | 1 + > .../sys/module/bluetooth/sections/.text.unlikely | 1 + > .../sys/module/bluetooth/sections/__bug_table | 1 + > .../sys/module/bluetooth/sections/__jump_table | 1 + > .../sys/module/bluetooth/sections/__kcrctab | 1 + > .../sys/module/bluetooth/sections/__kcrctab_gpl | 1 + > .../sys/module/bluetooth/sections/__ksymtab | 1 + > .../sys/module/bluetooth/sections/__ksymtab_gpl | 1 + > .../module/bluetooth/sections/__ksymtab_strings | 1 + > .../sys/module/bluetooth/sections/__param | 1 + > .../show-depends/sys/module/bluetooth/srcversion | 1 + > .../show-depends/sys/module/bluetooth/taint | 1 + > .../show-depends/sys/module/bluetooth/version | 1 + > .../show-depends/sys/module/btusb/coresize | 1 + > .../sys/module/btusb/drivers/usb:btusb | 1 + > .../show-depends/sys/module/btusb/initsize | 1 + > .../show-depends/sys/module/btusb/initstate | 1 + > .../sys/module/btusb/notes/.note.gnu.build-id | Bin 0 -> 36 bytes > .../sys/module/btusb/parameters/disable_scofix | 1 + > .../sys/module/btusb/parameters/force_scofix | 1 + > .../sys/module/btusb/parameters/ignore_csr | 1 + > .../sys/module/btusb/parameters/ignore_dga | 1 + > .../sys/module/btusb/parameters/ignore_sniffer | 1 + > .../show-depends/sys/module/btusb/parameters/reset | 1 + > .../show-depends/sys/module/btusb/refcnt | 1 + > .../show-depends/sys/module/btusb/sections/.bss | 1 + > .../show-depends/sys/module/btusb/sections/.data | 1 + > .../sys/module/btusb/sections/.exit.text | 1 + > .../btusb/sections/.gnu.linkonce.this_module | 1 + > .../sys/module/btusb/sections/.init.text | 1 + > .../sys/module/btusb/sections/.note.gnu.build-id | 1 + > .../show-depends/sys/module/btusb/sections/.rodata | 1 + > .../sys/module/btusb/sections/.rodata.str1.1 | 1 + > .../sys/module/btusb/sections/.rodata.str1.8 | 1 + > .../sys/module/btusb/sections/.smp_locks | 1 + > .../show-depends/sys/module/btusb/sections/.strtab | 1 + > .../show-depends/sys/module/btusb/sections/.symtab | 1 + > .../show-depends/sys/module/btusb/sections/.text | 1 + > .../show-depends/sys/module/btusb/sections/__param | 1 + > .../show-depends/sys/module/btusb/srcversion | 1 + > .../show-depends/sys/module/btusb/taint | 1 + > .../show-depends/sys/module/btusb/version | 1 + > .../rootfs/test-new-module/from_alias/correct.txt | 2 + > .../from_alias/etc/modprobe.d/modprobe.conf | 1 + > .../rootfs/test-new-module/from_name/correct.txt | 6 +++ > testsuite/rootfs/test-rootfs/lib/modules/a | 1 + > 128 files changed, 237 insertions(+), 16 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
