Hi Dan, On Sat, Feb 4, 2012 at 12:29 AM, Dan McGee <dan@xxxxxxxxxxxxx> wrote: > Ensure this dependency is explicit in the Makefile so rebuilding just > one test works correctly. Also reduce some repetition in the test LDADD What exactly are you fixing here? > bits by adding a new TESTSUITE_LDADD variable. > > Signed-off-by: Dan McGee <dan@xxxxxxxxxxxxx> > --- > Makefile.am | 16 +++++++++------- > 1 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 69ab986..4c03dbb 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -163,11 +163,13 @@ EXTRA_DIST += testsuite/rootfs.tar.xz > TESTSUITE_CPPFLAGS = $(AM_CPPFLAGS) \ > -DTESTSUITE_ROOTFS=\"$(abs_top_builddir)/testsuite/rootfs/\" \ > -DABS_TOP_BUILDDIR=\"$(abs_top_builddir)\" > +TESTSUITE_LDADD = testsuite/libtestsuite.la libkmod/libkmod-private.la not every test depends on these 2 convenience library. Since they are only tests and we are garbage collecting unused symbols, maybe to ease the inclusion of more tests we can indeed do what you did. > > check_LTLIBRARIES += testsuite/libtestsuite.la > testsuite_libtestsuite_la_SOURCES = testsuite/testsuite.c \ > testsuite/testsuite.h > -testsuite_libtestsuite_la_DEPENDENCIES = testsuite/rootfs > +testsuite_libtestsuite_la_DEPENDENCIES = testsuite/rootfs \ > + $(TESTSUITE_OVERRIDE_LIBS) humn.... /me thinking. You are only serializing the build and telling autofoo to rebuild libtestsuite.la if, for example, testsuite/path.c changes. However testsuite/path.c will be a separate dynamic lib. There's no need to rebuild libtestsuite if we change it. The same apply for the other libs (the ones in TESTSUITE_OVERRIDE_LIBS). Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
