Re: Should modprobe blacklist all or only canned aliases?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2010-08-17 at 08:21 +0200, Kay Sievers wrote:
> On Tue, Aug 17, 2010 at 07:37, Jon Masters <jcm@xxxxxxxxxx> wrote:
> > On Sun, 2010-08-15 at 21:44 +0400, Andrey Borzenkov wrote:
> >
> >> According to manual page for modprobe.conf(5), only canned aliases taken
> >> from kernel modules are blacklisted:
> >>
> >>     Modules can contain their own aliases: usually these are aliases
> >>     describing the devices they support, such as "pci:123...". These
> >>     "internal" aliases can be overridden by normal "alias" keywords,
> >>     but there are cases where two or more modules both  support  the
> >>     same  devices,  or a module invalidly claims to support a device
> >>     that it does not: the blacklist keyword indicates  that  all  of
> >>     that particular module's internal aliases are to be ignored.
> >>
> >> But as written now, modprobe applies blacklist to all modules, both read
> >> from configuration files as well as from modules.alias.
> >
> > Ah, I see what you're saying. Can you tell me how this is affecting you?
> > I will review your patch in any case.
> 
> We need blacklist entries applied to configured aliases. There should
> be no difference where an alias is coming from. Blacklist entries must
> always win, regardless of the source of the alias. Please change only
> the documentation.

Right. I should say "review" there doesn't mean change behavior. My
reply was intended to be a nice way of asking why he thought this was
required :) I think only the docs need fixing, and that is my plan.

Jon.


--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux