Andreas Robinson wrote: > On Thu, 2009-06-11 at 16:35 +0100, Alan Jenkins wrote: > >> The following changes since commit c6fb42a68462729c4dfda59b8fc5f9c84c58b68b: >> Jon Masters (1): >> testsuite: rebuild all the 64-be|le data files >> >> are available in the git repository at: >> >> git@xxxxxxxxxx:sourcejedi/module-init-tools.git master >> >> or may be reviewed online at: >> >> http://github.com/sourcejedi/module-init-tools/commits/master >> >> Alan Jenkins (8): >> Re-order options to make the code easier to check >> Clean up missing options >> depmod --warn doesn't has_arg >> modprobe: don't ignore --set-version when preceded by --dirname >> modprobe: --remove requires at least one module name >> depmod: simplify option error handling >> > > This one breaks the test suite for me. Other than that it looks good! > > -[ "`depmod --unknown 2>&1 | head -1`" = "depmod: unrecognized option \`--unknown'" ] > +[ "`depmod --unknown 2>&1 | head -1`" = "depmod: unrecognized option '--unknown'" Shucks, it worked for me. I did wonder about these `smart quotes' though. Thanks for testing (and reading) it. I guess we don't need the test any more. Since the message is now being generated by depmod instead of getopt, there's nothing for us to get wrong :-). I'll fix this in an extra commit and re-send the pull request. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
