On Mon, 2009-05-18 at 22:59 +0100, Alan Jenkins wrote: > On 5/18/09, Alan Jenkins <sourcejedi.lkml@xxxxxxxxxxxxxx> wrote: > > On 5/18/09, Andreas Robinson <andr345@xxxxxxxxx> wrote: > >> On Mon, 2009-05-18 at 17:14 +0100, Alan Jenkins wrote: > > That would require mapping the file as copy > > on write (private). But I _think_ we should be able to run on NOMMU, > > where that is not supported. > > Disregard, I thought wrong. modprobe already modifies module data to > implement the more nefarious options. Still, I would suggest using > fatal() instead. We should already have the module filename; we can > output a useful error message and exit(), without returning to the > caller. Ok, in this case load_strings() could deal with all strings-sections. Unlike next_string() it knows the module pathname. I'm putting it on the TODO-list Time to spend some time AFK. Good night, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html