Re: [PATCH 1/4] Clean up my_basename()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-04-22 at 09:19 +0100, Alan Jenkins wrote:
> On 4/21/09, Andreas Robinson <andr345@xxxxxxxxx> wrote:
> > Combines five implementations found in depmod.c, insmod.c, modprobe.c and
> > util.c.
> 
> Great, well done for picking up the open-coded versions.

Thanks.

> > +#define my_basename(path) ((strrchr((path), '/') ?: (path) - 1) + 1)
> 
> Ew.  This is the 21st century, aren't we allowed to use inline functions?

LOL! Certainly. I'm allergic to macros too. Consider it fixed.

/Andreas


--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux