Re: [PATCH 1/4] Create autogen.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 6, 2009 at 16:20, Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx> wrote:
> Kay Sievers wrote:
>> On Fri, Mar 6, 2009 at 15:48, Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>
>> wrote:
>>>
>>> Take the requisite autotools commands from the README and put them in
>>> autogen.sh.  This just makes it more convenient to build from GIT,
>>> especially when configure.ac or Makefile.am are changed.
>>>
>>> Signed-off-by: Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>
>>> diff --git a/README b/README
>>> index ef0b7ad..17c5cdf 100644
>>> --- a/README
>>> +++ b/README
>>> @@ -33,7 +33,7 @@ OR,
>>>       depmod 2.5.50
>>>
>>> 6) If you want to hack on the source:
>>> -       aclocal && automake --add-missing --copy && autoconf
>>> +       ./autogen.sh
>>>
>>> If this is all too complicated, I recommend getting and installing the
>>> source rpm or debian package instead.
>>> diff --git a/autogen.sh b/autogen.sh
>>> new file mode 100755
>>> index 0000000..ec043cc
>>> --- /dev/null
>>> +++ b/autogen.sh
>>> @@ -0,0 +1,3 @@
>>> +#! /bin/sh
>>> +
>>> +aclocal && automake --add-missing --copy && autoconf
>>
>> Isn't that just "autoreconf -i -s"?
>
> I created the script precisely because I'm not familiar with these commands,
> but I am used to running "./autogen.sh" :).  (And thus I suspect the same is
> true of others).

Yeah, me too, until Scott told me I could replace the custom stuff in
the udev tree. :)

> Yes, that works.  I guess I'll send a new patch, drop autogen.sh and just
> update the README.

Yeah, there is no real point for autogen.sh, if it does not add
anything custom. I kept it in the udev tree only to specify the
compile options and warnings, because they don't really belong into
the configure.ac or the Makefiles.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux