Hi Wolfram Sang,
Thanks for the feedback.
> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Sent: 28 February 2025 21:25
> Subject: Re: [PATCH v4 2/2] mmc: renesas_sdhi: Add support for RZ/G3E SoC
>
>
> > +static struct regulator_desc renesas_sdhi_vqmmc_regulator = {
> > + .of_match = of_match_ptr("vqmmc-regulator"),
> > + .owner = THIS_MODULE,
> > + .type = REGULATOR_VOLTAGE,
> > + .ops = &renesas_sdhi_regulator_voltage_ops,
> > + .volt_table = renesas_sdhi_vqmmc_voltages,
> > + .n_voltages = ARRAY_SIZE(renesas_sdhi_vqmmc_voltages),
> > +};
>
> ...
>
> > + renesas_sdhi_vqmmc_regulator.name = "sdhi-vqmmc-regulator";
> > + renesas_sdhi_vqmmc_regulator.of_match = of_match_ptr("vqmmc-regulator");
> > + renesas_sdhi_vqmmc_regulator.type = REGULATOR_VOLTAGE;
> > + renesas_sdhi_vqmmc_regulator.owner = THIS_MODULE;
>
> ?
Oops. I will move .name to struct initializer and drop this redundant
Assignmets.
>
> Also, one space only before '=' in the struct initializer.
OK. Will fix it in next version.
Cheers,
Biju
