Hi Wolfram,
> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Sent: 27 February 2025 15:16
> Subject: Re: [PATCH v3 3/8] mmc: renesas_sdhi: Add support for RZ/G3E SoC
>
>
> > + /*
> > + * HW reset might have toggled the regulator state in
> > + * HW which regulator core might be unaware of so save
> > + * and restore the regulator state during HW reset.
> > + */
>
> Since this is a hard reset, can't we just reset the regulator to an initial state? It seems strange to
> preserve a value when the 'preserve' flag is explicitly not set.
For internal regulator case this also works OK. In this case, we don't need to preserve the value.
This avoids changing internal vqmmc regulator from 1.8V to 3.3V during UHS state.
Currently hardware reset causes vqmmc regulator to change from 1.8V to 3.3V.
- if (!preserve) {
+ if (!preserve && !priv->rdev) {
Please share your thoughts.
Cheers,
Biju
