Hi Wolfram, Thanks for the feedback. > -----Original Message----- > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Sent: 27 February 2025 15:16 > Subject: Re: [PATCH v3 3/8] mmc: renesas_sdhi: Add support for RZ/G3E SoC > > > > + /* > > + * HW reset might have toggled the regulator state in > > + * HW which regulator core might be unaware of so save > > + * and restore the regulator state during HW reset. > > + */ > > Since this is a hard reset, can't we just reset the regulator to an initial state? It seems strange to > preserve a value when the 'preserve' flag is explicitly not set. Assume, this happens after the card is switched to UHS state and then the command won't work in UHS state if we bring the regulator initial state of 3.3V , In external regulator case, we don't toggle the regulator to initial state of 3.3V. That is the reason it is still working even when hard reset is applied in UHS state. Am I missing anything please let me know? I can debug further. Cheers, Biju
