On Fri, Jan 31, 2025 at 10:25 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote: > > Reduce verbosity by using gpiods_set_array_value_cansleep() instead of > gpiods_set_array_value_cansleep(). > > ddata->cmd_gpios->ndescs is validated to be equal to > PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same > value as the previously hard-coded argument. ... > static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, int val) > > values[0] = val; FWIW, side note: this code is (potentially) buggy on BE 64-bit. Same for the rest of similar cases, in case you want to address this... -- With Best Regards, Andy Shevchenko
