Hi Biju,
On Sun, 26 Jan 2025 at 14:46, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> The SDHI/eMMC IPs in the RZ/G3E SoC are similar to those in R-Car Gen3.
> However, the RZ/G3E SD0 channel has Voltage level control and PWEN pin
> support via SD_STATUS register.
>
> internal regulator support is added to control the voltage levels of
> the SD pins via sd_iovs/sd_pwen bits in SD_STATUS register by populating
> vqmmc-regulator child node.
>
> SD1 and SD2 channels have gpio regulator support and internal regulator
> support. Selection of the regulator is based on the regulator phandle.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -1053,6 +1165,23 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> if (ret)
> goto efree;
>
> + rcfg.of_node = of_get_child_by_name(dev->of_node, "vqmmc-regulator");
If this node becomes required on RZ/V2H and RZ/G3E, and controlled
through status, you also need:
if (!of_device_is_available(rcfg.of_node)) {
of_node_put(rcfg.of_node);
rcfg.of_node = NULL;
}
Or introduce of_get_available_child_by_name()...
> + if (rcfg.of_node) {
> + rcfg.driver_data = priv->host;
> +
> + renesas_sdhi_vqmmc_regulator.name = "sdhi-vqmmc-regulator";
Name conflict in case of multiple instances?
> + renesas_sdhi_vqmmc_regulator.of_match = of_match_ptr("vqmmc-regulator");
> + renesas_sdhi_vqmmc_regulator.type = REGULATOR_VOLTAGE;
> + renesas_sdhi_vqmmc_regulator.owner = THIS_MODULE;
> + rdev = devm_regulator_register(dev, &renesas_sdhi_vqmmc_regulator, &rcfg);
> + of_node_put(rcfg.of_node);
> + if (IS_ERR(rdev)) {
> + dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev));
> + goto efree;
> + }
> + priv->rdev = rdev;
> + }
> +
> ver = sd_ctrl_read16(host, CTL_VERSION);
> /* GEN2_SDR104 is first known SDHI to use 32bit block count */
> if (ver < SDHI_VER_GEN2_SDR104 && mmc_data->max_blk_count > U16_MAX)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
