On Fri, Dec 13, 2024 at 01:56:04PM +0100, Konrad Dybcio wrote:
> On 6.12.2024 3:37 AM, Yuanjie Yang wrote:
> > Add SDHC1 and SDHC2 support to the QCS615 Ride platform.
> >
> > Signed-off-by: Yuanjie Yang <quic_yuanjiey@xxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/qcs615.dtsi | 209 +++++++++++++++++++++++++++
> > 1 file changed, 209 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > index 590beb37f441..e52bf8c77884 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > @@ -399,6 +399,72 @@ qfprom: efuse@780000 {
> > #size-cells = <1>;
> > };
> >
> > + sdhc_1: mmc@7c4000 {
> > + compatible = "qcom,qcs615-sdhci", "qcom,sdhci-msm-v5";
> > + reg = <0x0 0x007c4000 0x0 0x1000>,
> > + <0x0 0x007c5000 0x0 0x1000>,
> > + <0x0 0x007c8000 0x0 0x8000>;
> > + reg-names = "hc",
> > + "cqhci",
> > + "ice";
> > +
> > + interrupts = <GIC_SPI 641 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 644 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "hc_irq",
> > + "pwr_irq";
> > +
> > + clocks = <&gcc GCC_SDCC1_AHB_CLK>,
> > + <&gcc GCC_SDCC1_APPS_CLK>,
> > + <&rpmhcc RPMH_CXO_CLK>,
> > + <&gcc GCC_SDCC1_ICE_CORE_CLK>;
> > + clock-names = "iface",
> > + "core",
> > + "xo",
> > + "ice";
> > +
> > + resets = <&gcc GCC_SDCC1_BCR>;
> > +
> > + power-domains = <&rpmhpd RPMHPD_CX>;
> > + operating-points-v2 = <&sdhc1_opp_table>;
> > + iommus = <&apps_smmu 0x02c0 0x0>;
> > + interconnects = <&aggre1_noc MASTER_SDCC_1 QCOM_ICC_TAG_ALWAYS
> > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
> > + &config_noc SLAVE_SDCC_1 QCOM_ICC_TAG_ALWAYS>;
>
> QCOM_ICC_TAG_ACTIVE_ONLY for the CPU path
OK, I will fix it in next patch.
> > + interconnect-names = "sdhc-ddr",
> > + "cpu-sdhc";
> > +
> > + qcom,dll-config = <0x000f642c>;
> > + qcom,ddr-config = <0x80040868>;
> > + supports-cqe;
> > + dma-coherent;
> > + status = "disabled";
>
> Nit: please add a newline before status for consistency
I will add a newline before status in next patch.
> (both comments apply to both controllers)
OK I will fix both controllers(SDHC_1 and SDHC_2).
> Konrad
Thanks,
yuanjie
