On Tue, Nov 26, 2024 at 05:07:11PM +0800, Yuanjie Yang wrote:
> On Mon, Nov 25, 2024 at 02:13:22PM +0100, Konrad Dybcio wrote:
> > On 22.11.2024 7:51 AM, Yuanjie Yang wrote:
> > > Add SDHC1 and SDHC2 support to the QCS615 Ride platform.
> > >
> > > Signed-off-by: Yuanjie Yang <quic_yuanjiey@xxxxxxxxxxx>
> > > ---
> > > arch/arm64/boot/dts/qcom/qcs615.dtsi | 198 +++++++++++++++++++++++++++
> > > 1 file changed, 198 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > > index 590beb37f441..37c6ab217c96 100644
> > > --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > > @@ -399,6 +399,65 @@ qfprom: efuse@780000 {
> > > #size-cells = <1>;
> > > };
> > >
> > > + sdhc_1: mmc@7c4000 {
> > > + compatible = "qcom,qcs615-sdhci", "qcom,sdhci-msm-v5";
> > > + reg = <0x0 0x007c4000 0x0 0x1000>,
> > > + <0x0 0x007c5000 0x0 0x1000>;
> > > + reg-names = "hc",
> > > + "cqhci";
> >
> > There's an "ice" region at 0x007c8000
> Thanks, I check doc again, I miss "ice" region at 0x007c8000.
>
> > > +
> > > + interrupts = <GIC_SPI 641 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 644 IRQ_TYPE_LEVEL_HIGH>;
> > > + interrupt-names = "hc_irq",
> > > + "pwr_irq";
> > > +
> > > + clocks = <&gcc GCC_SDCC1_AHB_CLK>,
> > > + <&gcc GCC_SDCC1_APPS_CLK>,
> > > + <&rpmhcc RPMH_CXO_CLK>,
> > > + <&gcc GCC_SDCC1_ICE_CORE_CLK>;
> > > + clock-names = "iface",
> > > + "core",
> > > + "xo",
> > > + "ice";
> > > +
> > > + resets = <&gcc GCC_SDCC1_BCR>;
> > > +
> > > + power-domains = <&rpmhpd RPMHPD_CX>;
> > > + operating-points-v2 = <&sdhc1_opp_table>;
> > > + iommus = <&apps_smmu 0x02c0 0x0>;
> > > + interconnects = <&aggre1_noc MASTER_SDCC_1 QCOM_ICC_TAG_ALWAYS
> > > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> > > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
> > > + &config_noc SLAVE_SDCC_1 QCOM_ICC_TAG_ALWAYS>;
> > > + interconnect-names = "sdhc-ddr",
> > > + "cpu-sdhc";
> > > +
> > > + bus-width = <8>;
> > > + qcom,dll-config = <0x000f642c>;
> > > + qcom,ddr-config = <0x80040868>;
> > > + supports-cqe;
> > > + dma-coherent;
> > > + mmc-ddr-1_8v;
> > > + mmc-hs200-1_8v;
> > > + mmc-hs400-1_8v;
> > > + mmc-hs400-enhanced-strobe;
> > > + status = "disabled";
> > > +
> > > + sdhc1_opp_table: opp-table {
> > > + compatible = "operating-points-v2";
> > > +
> > > + opp-100000000 {
> > > + opp-hz = /bits/ 64 <100000000>;
> > > + required-opps = <&rpmhpd_opp_svs>;
> > > + };
> >
> > I'm seeing 25/50 MHz OPPs in the docs as well
> Thanks, I check doc again, I miss 50MHz OPPs, but I don't find 25MHz.
>
> > [...]
> >
> > > +
> > > + sdhc_2: mmc@8804000 {
> > > + compatible = "qcom,qcs615-sdhci","qcom,sdhci-msm-v5";
> >
> > Missing space
Thanks, I will add space in next version.
> > > + reg = <0x0 0x08804000 0x0 0x1000>;
> > > + reg-names = "hc";
> > > +
> > > + interrupts = <GIC_SPI 204 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
> > > + interrupt-names = "hc_irq",
> > > + "pwr_irq";
> > > +
> > > + clocks = <&gcc GCC_SDCC2_AHB_CLK>,
> > > + <&gcc GCC_SDCC2_APPS_CLK>,
> > > + <&rpmhcc RPMH_CXO_CLK>;
> > > + clock-names = "iface",
> > > + "core",
> > > + "xo";
> > > +
> > > + power-domains = <&rpmhpd RPMHPD_CX>;
> > > + operating-points-v2 = <&sdhc2_opp_table>;
> > > + iommus = <&apps_smmu 0x02a0 0x0>;
> > > + resets = <&gcc GCC_SDCC2_BCR>;
> > > + interconnects = <&aggre1_noc MASTER_SDCC_2 QCOM_ICC_TAG_ALWAYS
> > > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> > > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
> > > + &config_noc SLAVE_SDCC_2 QCOM_ICC_TAG_ALWAYS>;
> > > + interconnect-names = "sdhc-ddr",
> > > + "cpu-sdhc";
> > > +
> > > + bus-width = <4>;
> > > + qcom,dll-config = <0x0007642c>;
> > > + qcom,ddr-config = <0x80040868>;
> > > + dma-coherent;
> > > + status = "disabled";
> > > +
> > > + sdhc2_opp_table: opp-table {
> > > + compatible = "operating-points-v2";
> > > +
> >
> > Similarly, it can operate at 25/50 MHz too
> Thanks, I check doc again, I miss 50MHz OPPs, but I don't find 25MHz.
>
> >
> > Konrad
>
> Thanks,
> Yuanjie
>
Thanks,
Yuanjie
