> Hi Avril, Hi, thanks for having a look. > > 在 2024/11/6 20:18, Avri Altman 写道: > > While strict checkpatch is useful for identifying common style issues > > and enforcing certain coding standards, clang-format provides several > > advantages, e.g. automated formatting, customizable style, consistency > > across tools, and more. > > > > By adopting clang-format, we aim to improve code readability, > > maintainability, and overall code quality in the ufs core driver. > > > > It does improve the code a bit, however, my concern is that if this massive > change, maybe along with the following part 2 or so，will makes the git- > blame hard to follow the history? I understand your concern. It's true that large-scale formatting changes can make it harder to use `git blame` to trace the history of specific lines of code. This is why I limit this change to a single module. I am not planning to flood the mailing list with those changes, But to *slowly* convert formatting issues in the mmc core driver, and only those I can test. Also, this change is non-functional formatting only change - To make it easier to use `git blame` to trace functional changes without being affected by formatting changes. I also think that there are some git blame switches that help ignore formatting only changes, e.g. git blame -w. Thanks, Avri
