On Wed, Nov 06, 2024 at 09:10:57AM +0000, Dmitry Baryshkov wrote: > On 6 November 2024 07:56:57 GMT, Yuanjie Yang <quic_yuanjiey@xxxxxxxxxxx> wrote: > >On Wed, Nov 06, 2024 at 09:36:56AM +0200, Dmitry Baryshkov wrote: > >> On Wed, Nov 06, 2024 at 03:23:42PM +0800, Yuanjie Yang wrote: > >> > Add SDHC1 and SDHC2 support to the QCS615 Ride platform. The SDHC1 > >> > and SDHC2 of QCS615 are derived from SM6115. Include the relevant > >> > binding documents accordingly. > >> > >> Which binding documents? > >Thanks, the binding documents is sdhci-msm.yaml. > >I have modified this yaml patch in patch v1, and this yaml patch is > >applied, so I remove this yaml patch in patch v2. > >link:https://lore.kernel.org/all/CAPDyKFr-Gzd3Mzn+vN6DXO9C4Xrvpv4z5V2G_VRTzOa=89Fd3w@xxxxxxxxxxxxxx/ > > The question is why do you mention bindings in the DTSI commit message? Please don't just C&P your texts. Thanks, I will adjust commit message in next version. I will optimize my language expression again. > > > >> > Additionally, configure SDHC1-related > >> > and SDHC2-related opp, power, and interconnect settings in the device > >> > tree. > >> > > >> > Signed-off-by: Yuanjie Yang <quic_yuanjiey@xxxxxxxxxxx> > >> > --- > >> > arch/arm64/boot/dts/qcom/qcs615.dtsi | 198 +++++++++++++++++++++++++++ > >> > 1 file changed, 198 insertions(+) > >> > > >> > >> -- > >> With best wishes > >> Dmitry > > > >Thanks, > >Yuanjie > Thanks, Yuanjie
