On Sat, 28 Sept 2024 at 11:44, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > The debug message could still report success when getting the channels > was OK but configuring them failed. This actually caused a minor detour > when debugging DMA problems, so make sure the success is only reported > when the channels are really ready-to-use. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sh_mmcif.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c > index 08b4312af94e..0e7fa3e9c9fe 100644 > --- a/drivers/mmc/host/sh_mmcif.c > +++ b/drivers/mmc/host/sh_mmcif.c > @@ -439,14 +439,15 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host *host) > if (IS_ERR(host->chan_rx)) > host->chan_rx = NULL; > } > - dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx, > - host->chan_rx); > > if (!host->chan_tx || !host->chan_rx || > sh_mmcif_dma_slave_config(host, host->chan_tx, DMA_MEM_TO_DEV) || > sh_mmcif_dma_slave_config(host, host->chan_rx, DMA_DEV_TO_MEM)) > goto error; > > + dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx, > + host->chan_rx); > + > return; > > error: > -- > 2.45.2 >
