On 07/10/2024 12:14, AngeloGioacchino Del Regno wrote: > Il 07/10/24 10:37, Frank Wunderlich ha scritto: >> Hi >> >>> Gesendet: Montag, 07. Oktober 2024 um 09:58 Uhr >>> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx> >>> Betreff: Re: [PATCH v2 2/2] mmc: mtk-sd: add support for mt7988 >>> >>> Il 06/10/24 17:34, Frank Wunderlich ha scritto: >>>> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >>>> >>>> Add support for mmc on MT7988 SoC. >>>> >>>> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >>> >>> There's no need to add yet one more duplicate mtk_mmc_compatible platform >>> data, nor one more compatible string to this driver, as this is exactly >>> the same as mt7986. >>> >>> Please reuse the MT7986 compatible; in DT you'll have: >>> >>> compatible = "mediatek,mt7988-mmc", "mediatek,mt7986-mmc"; >> >> as explained in binding, the clock config is completely different (except first 2 also required by driver - 3-7 are optional there). mt7988 uses axi and ahb clocks. >> >> but i could of course use the mt7988 compatible with mt7986 compat data...but looked dirty to me so just copied the block (to allow later changes if needed). >> > > In case there will be any changes required *later*, you can always add new platform > data for the MT7988 compatible, as it's just only a code change and nothing else. > > For now, since they're the same, just reuse mt7986_compat. > > Reusing is way better than duplicating - here and everywhere else - especially when > this implies a 100% duplication. If you use same match data, then entire change should be dropped because it is redundant. Instead express compatibility in the bindings and use fallback. Best regards, Krzysztof
