> On Thu, 3 Oct 2024 at 18:31, Avri Altman <Avri.Altman@xxxxxxx> wrote: > > > > > > +int mmc_send_ext_addr(struct mmc_host *host, u32 addr) { > > > > + struct mmc_command cmd = { > > > > + .opcode = SD_ADDR_EXT, > > > > + .arg = addr, > > > > + .flags = MMC_RSP_R1 | MMC_CMD_AC, > > > > + }; > > > > + > > > > + if (!mmc_card_ult_capacity(host->card)) > > > > + return 0; > > > > + > > > > + return mmc_wait_for_cmd(host, &cmd, 0); } > > > > +EXPORT_SYMBOL_GPL(mmc_send_ext_addr); > > > > > > This doesn't need to be exported as it's only used by the core module. > > I've got a kernel test robot warning on this in v1: > > https://www.spinics.net/lists/linux-mmc/msg81530.html > > I don't recall how the code looked in v1. Probably there was a call to > mmc_send_ext_addr() from the mmc block device driver that isn't there > anymore, which seems very much correct to me. > > You can for sure drop the EXPORT_SYMBOL_GPL from here, it isn't needed. OK. Thanks, Avri > > Kind regards > Uffe