On 25/09/2024 19:29, Martin Blumenstingl wrote: > Hi Krzysztof, > > On Tue, Sep 24, 2024 at 11:18 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > [...] >>> + enum: [0, 1, 2] >>> + >>> + bus-width: >>> + enum: [1, 4] >>> + >>> + unevaluatedProperties: false >> >> Hm, I wonder why not all slots are defined in your DTS? Why not all of >> them are required? I assume the slots are there always, as part of the >> controller. >> >> Is this because of driver limitation mentioned in the old binding? > The MMC core (still) has a limitation of only supporting one slot per > controller - so a limitation will stay in place. > > However, the driver (drivers/mmc/host/meson-mx-sdio.c) uses > of_get_compatible_child(), meaning it will also pick the first child > node with the correct compatible string, even if it has status = > "disabled". > I can send a patch to reduce the scope of this limitation: all slots > can be defined but only the first enabled one is used. > What do you think? For the conversion it can stay as is. Follow-up patches allowing multiple slots, adding them in DTC etc. are nice, but not necessary here. Best regards, Krzysztof
