> -----Original Message-----
> From: Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>
> Sent: 2024年9月23日 14:20
> To: Bough Chen <haibo.chen@xxxxxxx>; adrian.hunter@xxxxxxxxx;
> ulf.hansson@xxxxxxxxxx
> Cc: shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; imx@xxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; dl-S32
> <S32@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Peng Fan <peng.fan@xxxxxxx>
> Subject: [PATCH] mmc: sdhci-esdhc-imx: enable quirks SDHCI_QUIRK_NO_LED
>
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Enable SDHCI_QUIRK_NO_LED for i.MX7ULP, i.MX8MM, i.MX8QXP and
> i.MXRT1050. Even there is LCTL register bit, there is no IOMUX PAD for it. So
> there is no sense to enable LED for SDHCI for these SoCs.
>
Reasonable.
Reviewed-by: Haibo Chen <haibo.chen@xxxxxxx>
Regards
Haibo Chen
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 8f0bc6dca2b0..ef3a44f2dff1 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -238,6 +238,7 @@ struct esdhc_platform_data {
>
> struct esdhc_soc_data {
> u32 flags;
> + u32 quirks;
> };
>
> static const struct esdhc_soc_data esdhc_imx25_data = { @@ -309,10 +310,12
> @@ static struct esdhc_soc_data usdhc_imx7ulp_data = {
> | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
> | ESDHC_FLAG_PMQOS | ESDHC_FLAG_HS400
> | ESDHC_FLAG_STATE_LOST_IN_LPMODE,
> + .quirks = SDHCI_QUIRK_NO_LED,
> };
> static struct esdhc_soc_data usdhc_imxrt1050_data = {
> .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200,
> + .quirks = SDHCI_QUIRK_NO_LED,
> };
>
> static struct esdhc_soc_data usdhc_imx8qxp_data = { @@ -321,6 +324,7 @@
> static struct esdhc_soc_data usdhc_imx8qxp_data = {
> | ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
> | ESDHC_FLAG_STATE_LOST_IN_LPMODE
> | ESDHC_FLAG_CLK_RATE_LOST_IN_PM_RUNTIME,
> + .quirks = SDHCI_QUIRK_NO_LED,
> };
>
> static struct esdhc_soc_data usdhc_imx8mm_data = { @@ -328,6 +332,7 @@
> static struct esdhc_soc_data usdhc_imx8mm_data = {
> | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
> | ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
> | ESDHC_FLAG_STATE_LOST_IN_LPMODE,
> + .quirks = SDHCI_QUIRK_NO_LED,
> };
>
> struct pltfm_imx_data {
> @@ -1687,6 +1692,7 @@ static int sdhci_esdhc_imx_probe(struct
> platform_device *pdev)
>
> imx_data->socdata = device_get_match_data(&pdev->dev);
>
> + host->quirks |= imx_data->socdata->quirks;
> if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS)
> cpu_latency_qos_add_request(&imx_data->pm_qos_req, 0);
>
> --
> 2.37.1
