On 9/19/2024 5:56 PM, Krzysztof Kozlowski wrote:
On 13/09/2024 14:12, Sricharan R wrote:
From: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
Add binding for the Qualcomm IPQ5424 Global Clock Controller
Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
---
.../bindings/clock/qcom,ipq5424-gcc.yaml | 58 ++++
include/dt-bindings/clock/qcom,ipq5424-gcc.h | 156 +++++++++
include/dt-bindings/reset/qcom,ipq5424-gcc.h | 310 ++++++++++++++++++
3 files changed, 524 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq5424-gcc.yaml
create mode 100644 include/dt-bindings/clock/qcom,ipq5424-gcc.h
create mode 100644 include/dt-bindings/reset/qcom,ipq5424-gcc.h
diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq5424-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq5424-gcc.yaml
new file mode 100644
index 000000000000..af2d0cec43f3
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,ipq5424-gcc.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,ipq5424-gcc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Global Clock & Reset Controller on IPQ5424
+
+maintainers:
+ - Bjorn Andersson <andersson@xxxxxxxxxx>
+
+description: |
+ Qualcomm global clock control module provides the clocks, resets and power
+ domains on IPQ5424.
+
+ See also::
Just single :
ok
+ include/dt-bindings/clock/qcom,gcc-ipq5424.h
+ include/dt-bindings/reset/qcom,ipq5424-gcc.h
Wrong path
ok, will fix
+
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+properties:
+ compatible:
+ const: qcom,ipq5424-gcc
So everything i sthe same as 5332? Why not adding it there?
infact, ipq5332 has 1 dual lane and 1 single lane pcie, whereas
ipq5424 has 2 dual lane and 2 single lane pcie. will update the
bindings in v2 accordingly.
+++ b/include/dt-bindings/reset/qcom,ipq5424-gcc.h
@@ -0,0 +1,310 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2018,2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
2024 (other places and other patches as well)
ok
Regards,
Sricharan