On Tue, 27 Aug 2024 at 09:34, zhangxirui <xirui.zhang@xxxxxxxx> wrote: > > This series use devm_clk_get_enabled() to simplify code > and avoids the calls to clk_disable_unprepare() I agree that it simplifies code - but it also changes the behaviour, in which order clocks are getting unprepared/disabled during the ->remove() phase. In other words, this needs to be thoroughly tested and not just considered as a trivial cleanup series. For example, if there is a PM domain attached to the mmc host device, is it really okay to allow powering-off the PM domain before the clocks are being gated? This could potentially happen if we apply the $subject series. Kind regards Uffe > > zhangxirui (9): > mmc: cavium-thunderx: Use devm_clk_get_enabled() helpers > mmc: davinci_mmc: Use devm_clk_get_enabled() helpers > mmc: dw_mmc-hi3798cv200: Use devm_clk_get_enabled() helpers > mmc: mvsdio: Use devm_clk_get_enabled() helpers > mmc: mxcmmc: Use devm_clk_get_enabled() helpers > mmc: mxs-mmc: Use devm_clk_get_enabled() helpers > mmc: sdhci: milbeaut: Use devm_clk_get_enabled() helpers > mmc: sdhci-of-arasan: Use devm_clk_get_enabled() helpers > mmc: sdhci_f_sdh30: Use devm_clk_get_enabled() helpers > > drivers/mmc/host/cavium-thunderx.c | 7 +----- > drivers/mmc/host/davinci_mmc.c | 8 +----- > drivers/mmc/host/dw_mmc-hi3798cv200.c | 28 +++------------------ > drivers/mmc/host/mvsdio.c | 13 +++------- > drivers/mmc/host/mxcmmc.c | 25 +++---------------- > drivers/mmc/host/mxs-mmc.c | 13 +++------- > drivers/mmc/host/sdhci-milbeaut.c | 25 +++---------------- > drivers/mmc/host/sdhci-of-arasan.c | 31 ++++------------------- > drivers/mmc/host/sdhci_f_sdh30.c | 36 ++++++++------------------- > 9 files changed, 35 insertions(+), 151 deletions(-) > > -- > 2.25.1 >
