Ritesh Harjani <ritesh.list@xxxxxxxxx> writes: > Seunghwan Baek <sh8267.baek@xxxxxxxxxxx> writes: > >> To check if mmc cqe is in halt state, need to check set/clear of CQHCI_HALT >> bit. At this time, we need to check with &, not &&. >> >> Fixes: 0653300224a6 ("mmc: cqhci: rename cqhci.c to cqhci-core.c") Correction. This should be: Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host") Subject can be: mmc: cqhci: Fix checking of CQHCI_HALT state >> Cc: stable@xxxxxxxxxxxxxxx >> Signed-off-by: Seunghwan Baek <sh8267.baek@xxxxxxxxxxx> >> --- >> drivers/mmc/host/cqhci-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks for fixing it! > Small suggestion below. But this still looks good to me, so either ways- > > Reviewed-by: Ritesh Harjani <ritesh.list@xxxxxxxxx> With above changes please feel free to add RVB. -ritesh