On Tue, 6 Aug 2024 at 03:36, Keita Aihara <keita.aihara@xxxxxxxx> wrote:
>
> On Mon, Aug 05, 2024 at 12:14:25PM +0200, Ulf Hansson wrote:
> > On Fri, 2 Aug 2024 at 05:21, Keita Aihara <keita.aihara@xxxxxxxx> wrote:
> > >
> > > Applying MMC_QUIRK_BROKEN_SD_CACHE is broken, as the card's extended
> > > registers are parsed prior to the quirk being applied in mmc_blk.
> >
> > In what way is it a problem to read the extended registers first?
>
> SD quirks are referenced by mmc_card_broken_sd_cache() in
> sd_parse_ext_reg_perf(). If the quirk is set, SD_EXT_PERF_CACHE is not
> set to card->ext_perf.feature_support and the cache support will not be
> enabled.
>
> Therefore, SD quirks should be initialized before parsing the extension
> registers.
Makes perfect sense! Please include some of this information in the
commit message to make this clear.
>
> >
> > >
> > > Split this out into an SD-specific list of quirks and apply in
> > > mmc_sd_init_card instead.
> > >
> > > Fixes: c467c8f08185 ("mmc: Add MMC_QUIRK_BROKEN_SD_CACHE for Kingston Canvas Go Plus from 11/2019")
> > > Authored-by: Jonathan Bell <jonathan@xxxxxxxxxxxxxxx>
This tag isn't normally what we use. I suggest you change the author
of the patch to Jonathan and keep his sob-tag.
Then add yourself with a "Co-developed-by" tag and keep your sob-tag.
> > > Signed-off-by: Jonathan Bell <jonathan@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Keita Aihara <keita.aihara@xxxxxxxx>
[...]
Kind regards
Uffe
