Am Donnerstag, 15. August 2024, 02:55:37 CEST schrieb Shawn Lin: > Hi Detlev > > 在 2024/8/15 6:34, Detlev Casanova 写道: > > From: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> > > > > v2 tuning will inherit pre-stage loader's phase settings for the first > > time, and do re-tune if necessary. > > Re-tune will still try the rough degrees, for instance, 90, 180, 270, > > 360 but continue to do the fine tuning if sample window isn't good > > enough. > > > > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> > > Signed-off-by: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx> > > @@ -277,6 +322,10 @@ static int dw_mci_rk3288_parse_dt(struct dw_mci *host) > > &priv->default_sample_phase)) > > priv->default_sample_phase = 0; > > > > + priv->use_v2_tuning = > > + of_device_is_compatible(host->dev->of_node, > > + "rockchip,rk3576-dw-mshc"); > > + > > v2 is a kind of software decision instead of hardware dependency. > So in theory, any SoC can claim to use it via DT. which actually makes it unsuitable for dt. Devicetree describes hardware-properties and should _not_ be used for software configuration.