Hi Dan,
On 7/13/2024 5:53 PM, Dan Carpenter wrote:
129 if (mrq->cmd && !mrq->cmd->error &&
^^^^^^^^
If mrq->cmd is NULL
--> 154 mmc_request_done(host->mmc, mrq);
^^^
Then we are toasted because it will crash here
155 }
Ah, you're right. I was trying to be safe about never accessing null
pointers when I wrote the code, but since mmc_request_done also assumes
mrq->cmd is not null, it's pointless to check that here. I guess we must
already be guaranteed that it's never null at that point. Otherwise, all
sdhci drivers would crash.
Thanks for the heads up. I will submit a patch that removes the check
against mrq->cmd on line 129.
Doug
