Thank you Drew.
FYI, as per some inputs from Adrian, I will try to imrove the code and
send a new patch.
On 2024/4/29 9:40, Drew Fustini wrote:
On Sun, Apr 28, 2024 at 10:32:41AM +0800, Chen Wang wrote:
From: Chen Wang <unicorn_wang@xxxxxxxxxxx>
The current framework is not easily extended to support new SOCs.
For example, in the current code we see that the SOC-level
structure `rk35xx_priv` and related logic are distributed in
functions such as dwcmshc_probe/dwcmshc_remove/dwcmshc_suspend/......,
which is inappropriate.
The solution is to abstract some possible common operations of soc
into virtual members of `dwcmshc_priv`. Each soc implements its own
corresponding callback function and registers it in init function.
dwcmshc framework is responsible for calling these callback functions
in those dwcmshc_xxx functions.
Signed-off-by: Chen Wang <unicorn_wang@xxxxxxxxxxx>
I have tested this with the eMMC and microSD on the Lichee Pi 4a which
has the T-Head TH1520 SoC.
Tested-by: Drew Fustini <dfustini@xxxxxxxxxxxxxxx> # TH1520
Thanks,
Drew
